Skip to content

Refactor, Fixes, and functionality to avoid processing nested scroll events on internal webview elements scrolls #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023
Merged

Refactor, Fixes, and functionality to avoid processing nested scroll events on internal webview elements scrolls #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7edf209
ANDROID-13326 NestedScrollWebView refactor, fixes for detected issues…
dpastor May 24, 2023
d0f3a6e
ANDROID-13326 Extend implementation to cover both internal vertical a…
dpastor May 25, 2023
6d832ea
ANDROID-13326 Remove uneeded param and fix CS
dpastor May 25, 2023
d629d4c
ANDROID-11326 Remove non-null assertion
dpastor May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,17 @@ Just include directly the `NestedScrollWebView` in your layout:

## Configuration

Utility methods for specific WebView content requirements.

### Adjust WebView bottom margin to match CoordinatorLayout visible space

When expanding toolbar inside a CoordinatorLayout, instead of resizing the space left by the toolbar, it pushes down the content below.

This may be an issue for example for pages where a fixed footer element is displayed. So, in order to correctly resize the webview viewport on these expands you can add this attribute to the NestedScrollWebView.

`app:coordinatorBottomMatchingEnabled={"true"|"false"}`

This is disabled by default, as webview resizing is expensive.
This is **disabled by default**, as webview resizing is expensive.

```xml
<com.telefonica.nestedscrollwebview.NestedScrollWebView
Expand All @@ -101,13 +105,26 @@ This is disabled by default, as webview resizing is expensive.
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
```

## How we do it?
### Block vertical nested scrolling on WebView internal elements scrolls

Implementation extends [WebView](https://developer.android.com/reference/android/webkit/WebView) applying nested scrolling code logic from androidx.core [NestedScrollView](https://developer.android.com/reference/androidx/core/widget/NestedScrollView).
If your WebView content includes scrollable elements such as horizontal carousels or map views, nested scrolling should not be performed when scrolling these.

`app:blockNestedScrollingOnInternalContentScrolls={"true"|"false"}`

This is **enabled by default**, but can be disabled with this flag in case it does not work properly in any specific situation.

```xml
<com.telefonica.nestedscrollwebview.NestedScrollWebView
android:id="@+id/webView"
android:layout_width="match_parent"
android:layout_height="match_parent"
app:blockNestedScrollingOnInternalContentScrolls="false"
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
```

## Known issues, considerations and Future improvements
## How we do it?

* As implementation relies on NestedScrollView touch events interception, in cases there are web content elements that intercept movement events, for example a map view or a horizontal carousel, these movement events will be interpreted also as scrolling events for nested scrolling. We are thinking on a solution to prevent this.
Implementation extends [WebView](https://developer.android.com/reference/android/webkit/WebView) applying nested scrolling code logic from androidx.core [NestedScrollView](https://developer.android.com/reference/androidx/core/widget/NestedScrollView).

## Videos
<table>
Expand Down
Loading