-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable time column #5018
Nullable time column #5018
Conversation
Useful for turning off auto detection of time columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you also add a test that all the correct entities are created in the dataSource when using null
timeColumn and a timeseries CSV? Or at least the right number of entities. Maybe with this test file: https://github.com/TerriaJS/terriajs/blob/next/wwwroot/test/csv/lat_lon_timeseries.csv
There should be 11 entities created, one for each row (though they'll all be in 2 locations)
What this PR does
Makes
timeColumn
in table styles nullable. Useful for turning off auto-detection of time columns in tables.Checklist