Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable time column #5018

Merged
merged 6 commits into from
Jan 19, 2021
Merged

Nullable time column #5018

merged 6 commits into from
Jan 19, 2021

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Nov 26, 2020

What this PR does

Makes timeColumn in table styles nullable. Useful for turning off auto-detection of time columns in tables.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

Copy link
Member

@tephenavies tephenavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you also add a test that all the correct entities are created in the dataSource when using null timeColumn and a timeseries CSV? Or at least the right number of entities. Maybe with this test file: https://github.com/TerriaJS/terriajs/blob/next/wwwroot/test/csv/lat_lon_timeseries.csv

There should be 11 entities created, one for each row (though they'll all be in 2 locations)

@nf-s nf-s merged commit ee4b64d into next Jan 19, 2021
@nf-s nf-s deleted the nullable-time-column branch January 19, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants