Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TableTimeStyleTraits.timeColumn nullable #5133

Closed
wants to merge 2 commits into from
Closed

Make TableTimeStyleTraits.timeColumn nullable #5133

wants to merge 2 commits into from

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jan 12, 2021 •
edited
Loading

Make TableTimeStyleTraits.timeColumn nullable

This is needed to disable TableMixin autodetected time columns - for example:

{
"name": "Transmission substations",
  "url": "https://uts-nom.herokuapp.com/capacity/published/combined-transmission-substations.csv",
  "type": "csv",
  "tableStyle": {
    "timeColumn": null,
"..."

Test AREMI catalog: https://gist.githubusercontent.com/nf-s/9ff1422d9528c16a9e71403ec720558a/raw/fe86f1c9bf2dd4053148475dd1361fc7e205ec22/aremi-elec-infra.json

Checklist

  • Doesn't require tests
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s mentioned this pull request Jan 12, 2021
Closed
@nf-s
Copy link
Contributor Author

nf-s commented Jan 12, 2021

Dupe: #5018

@nf-s nf-s closed this Jan 12, 2021
@nf-s nf-s deleted the timeColumn-nullable branch January 12, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-CSV/Region Mapping High priority P-AREMI Z-Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nf-s