Skip to content

Add reactions_1 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChenWanyu1207
Copy link



class Reactioons(RestClient):
def list_reactions_for_a_commit_comment(self, owner, repo, comments,**kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.参数错了。
GET /repos/:owner/:repo/comments/:comment_id/reactions
这里comment_id是参数,而不是comments是参数。

def list_reactions_for_a_commit_comment(self, owner, repo, comments,**kwargs):
"""
https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment
:param owner:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.docstring文档不齐。空着是不行的

@zhangting85
Copy link
Contributor

已评审,请修改后重新提交。

@zhangting85 zhangting85 closed this May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants