Skip to content

Add reactions_1 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add reactions_1 #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions api/reactions/reactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from core.rest_client import RestClient


class Reactioons(RestClient):
def list_reactions_for_a_commit_comment(self, owner, repo, comments,**kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.参数错了。
GET /repos/:owner/:repo/comments/:comment_id/reactions
这里comment_id是参数，而不是comments是参数。

"""
https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment
:param owner:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.docstring文档不齐。空着是不行的

:param repo:
:param comments:
:param kwargs:
:return:
"""
return self.get("/repos/{}/{}/comments/{}/reactions".format(owner, repo,comments), **kwargs)