Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1878] Patch system data loader bug and test email workflow rules persistence on reload #1886

Closed
wants to merge 3 commits into from

Conversation

wwelling
Copy link
Collaborator

@wwelling wwelling commented Dec 23, 2023

Resolves #1878

Superseded by #1887

@@ -411,30 +411,22 @@ private void loadOrganization() {
organization = organizationRepo.create(systemOrganization.getName(), category);
organization.setAcceptsSubmissions(systemOrganization.getAcceptsSubmissions());
}
// else set systemOrganization to existing organization
else {
systemOrganization = organization;
Copy link
Collaborator Author

@wwelling wwelling Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System organization is a non-entity managed object which is object mapped from the JSON file /organization/SYSTEM_Organization_Definition.json. Reassigning as the entity managed organization is not necessary.


Organization organization = organizationRepo.findById(1L).get();
private void processEmailWorflowRules(Organization organization, Organization systemOrganization) {
List<EmailWorkflowRule> emailWorkflowRules = organization.getEmailWorkflowRules();
Copy link
Collaborator Author

@wwelling wwelling Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets the already persisted email workflow rules from the initial institute (top-level) organization. They are later saved along any from the system defaults not already persisted. This only applies to the initial system institution organization.

@wwelling
Copy link
Collaborator Author

Closing manually, #1887 squash merged into 3d959cc.

@wwelling wwelling closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebooting resets email workflow rules
1 participant