Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactor, cleanup, and additional patches #1887

Merged
merged 48 commits into from
Jan 16, 2024
Merged

[Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactor, cleanup, and additional patches #1887

merged 48 commits into from
Jan 16, 2024

Conversation

wwelling
Copy link
Collaborator

@wwelling wwelling commented Dec 29, 2023 •
edited
Loading

Resolves #1883
Resolves #1879
Resolves #1878
Resolves #1877
Resolves #1876
Resolves #1766
Resolves #1682

@wwelling
Fix email workflow rules resetting on restart
6adbcab
@wwelling
Switch application initialization to initializing bean
95ce645
@wwelling
Have abstract email recipient implement email recipient
9425e6b
@wwelling
Make default collections class members final and remove unused methods
bf2b392
@wwelling
Minor cleanup of integration tests
8974332
@wwelling
Remove unused imports
30fa312
@wwelling
More cleanup
f1bf6f9
@wwelling
Organize imports and return rule id in payload of create new email wo…
5c6c0c4 
…rkflow rule
@wwelling
Use mock mvc to call controller in email workflow rule integration tests
e54aedb
@wwelling
Initial breaking system data loader test
0217b72
@wwelling
Decouple submission list column default services
78309e3
@wwelling
Fix broken test due to immutable in memory defaults
2caff3e
@wwelling
Decouple system default settings from system data loader
55439e4
@wwelling
Decouple loading in memory proquest codes from persisting controlled …
01c8da4 
…vocabulary
@wwelling
Decouple initializing depositor services from system data loader
319fd14
@wwelling
Reorder system data loader methods according to use in class
4276717
@wwelling
Directly use resource pattern resolver during system data loading
47035da
@wwelling
Fix submission controller indentation
c9f320a
@wwelling
Add private constructor for ORCID utility
0494d5f
@wwelling
Correct registration error response message
5d93951
@wwelling
Only set default columns on user before create/persist
3daa5ae
@wwelling
Fix ORCiD authentication - issue 1877
522b885 
For authentication the following must match:

- ORCiD given-names must match first name input exactly
- ORCiD family-name must match last name input exactly
- ORCiD email be public and match email input exactly
@wwelling
Avoid null pointer exception
bcace83
@wwelling
Remove redundant superinterface
c2e8212
@wwelling
Consistently format system default JSON
042395c
@wwelling
Simplify system submission status loading
4ec8d06
@wwelling
Use field profile heritable repo delete and remove orphaned submissio…
3abc1d0 
…n list column - issue 1876
@wwelling
Keyboard accessible organization triptych
635cca0
@wwelling wwelling changed the title [Issue 1878, 1877, 1876] System data loader refactoring - Issue 1878 continued [Issue 1878, 1877, 1876, 1766] System data loader refactoring - Issue 1878 continued Dec 29, 2023
@wwelling
Remove unused dependency injection and scope variable
56672ca
@wwelling
Close modal and wait before location change on submission delete
4fc58eb 
This works okay but may have different experiences on different browsers.
@wwelling
Remove modal backdrop manually - issue 1879
086d593 
App ModelService can be removed and update .wvr/build-config.js to include @wvr/core ModelService if and when TAMULib/Weaver-UI-Core#241 is approved, merged, and released.
@wwelling
Update file upload to large message with max file size - issue 1883
5d03e49
@wwelling
Adjust line height of drop zone message
07e1d7a
@wwelling wwelling changed the title [Issue 1878, 1877, 1876, 1766] System data loader refactoring - Issue 1878 continued [Issue 1883,1879,1878,1877,1876,1766,1682] Issue 1878 continued - System data loader refactoring + Dec 29, 2023
@wwelling wwelling changed the title [Issue 1883,1879,1878,1877,1876,1766,1682] Issue 1878 continued - System data loader refactoring + [Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactoring and additional patches Dec 29, 2023
@wwelling wwelling marked this pull request as ready for review December 29, 2023 22:55
@wwelling wwelling changed the title [Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactoring and additional patches [Issue 1883,1879,1878,1877,1876,1766,1682] 1878 continued - System data loader refactor, cleanup, and additional patches Dec 30, 2023
@wwelling wwelling mentioned this pull request Dec 31, 2023
Closed
@cstarcher cstarcher changed the base branch from main to 4.2.6_staging January 8, 2024 02:34
@cstarcher
Copy link
Member

cstarcher commented Jan 8, 2024 •
edited
Loading

I have reviewed the PR with the following results:

#1883 - Resolved
#1879 - Resolved
#1877 - Resolved
#1682 - Resolved

#1878 - I would like @smutniak to review this to confirm resolution.

#1876 - This fully resolves the issue as described. However, when deleting a field that is already being used as a Customize Column in List view, an error message is generated and the field is deleted from the Workflow Step field list but not from the Customize Columns. This creates a field value that exists but cannot be removed from the Customize Columns. The solution would be to validate that the field has not been assigned to the List view before deletion.

#1766 - This addresses the ability to tab into the triptych. However, when there are multiple workflows listed in the triptych, subsequent tabs moves to the last workflow before moving to the Start Submission button preventing the user from selecting any workflows except the last one.

smutniak
smutniak approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@smutniak smutniak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some testing an review as best i could but the real test will be on a few sites incurring problems. I'll merge into the staging branch and try a few deploys. This PR supercedes 1886 correct?

@smutniak smutniak merged commit 3d959cc into TexasDigitalLibrary:4.2.6_staging Jan 16, 2024
1 check passed
@cstarcher
Copy link
Member

I am receiving this error when I select the Default columns button in List view and in the Customize Results Table modal.

2024-01-18 13:45:37.930 ERROR 64188 --- [nio-9000-exec-3] o.t.v.c.SubmissionListController : null
java.lang.UnsupportedOperationException: null
at java.base/java.util.Collections$UnmodifiableCollection.clear(Collections.java:1079) ~[na:na]

This was referenced Jan 23, 2024
Merged
Merged
@cstarcher cstarcher mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smutniak smutniak smutniak approved these changes

@cstarcher cstarcher Awaiting requested review from cstarcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wwelling @cstarcher @smutniak