-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CircleCI #1210
Set up CircleCI #1210
Conversation
0ac039c
to
bfc203b
Compare
f0a64f5
to
2f5b3f4
Compare
5cb166a
to
695a803
Compare
6452022
to
b535b8d
Compare
77ae689
to
639a6b8
Compare
a6766fe
to
1d9f99a
Compare
7b49e36
to
2b8c5af
Compare
🚫 CI failed with log |
@Adlai-Holler with regards to pricing, how long do the builds take on circle ci? The pricing indicates 500 minutes a month for the $40. |
# - {attach_workspace: {at: ~/project}} | ||
- checkout | ||
- {run: {name: 'Fetch cocoapods spec repo from cache', command: "curl https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh | bash -s cf\n"}} | ||
- {run: xcrun simctl list} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't, the simulator engine sometimes barfs when it comes time to run
@@ -0,0 +1,189 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why to create a new .sh file instead of updating the existing one? It would be nice for people to still be able to invoke a build script via command line and not have it diverge over time from the one CI was running. I see the pod install is happening elsewhere now, maybe we can use another ENV var or argument to disable it and then keep just one file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a leftover from the development of the diff. If we want to do this I will replace the old build.sh before landing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No time like the present! Are you anticipating a lag between merging the PR and actually running CI on CircleCI?
@Adlai-Holler let’s close this in favor of GitHub CI. It’s free for open source projects with no limitations that I know of. And it’s fast too! |
@maicki @appleguy @nguyenhuy @garrettmoon
What do we think? CircleCI is working, and fast. Unit tests finish in 7 minutes, and the last test (examples-pt2) finishes about 7 minutes later). Pricing is here https://circleci.com/pricing/#build-os-x
Notes:
All we have to do is decide:
If we decide to do it, all we have to do is:
Build list: https://circleci.com/gh/TextureGroup/Texture