Rework ASTraitCollection to Fix Warnings and Remove Boilerplate #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Nov 5, 2018
|
The CI broke:
The latter pattern doesn't scale. We should upgrade the CI to Xcode 10. Take a look at diff #1210!! EDIT: I added the macro |
Adlai-Holler
force-pushed
the
AHMoreWarnings
branch
from
217864f
to
1f29061
Compare
Generated by 🚫 Danger |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…ureGroup#1211) * Clean up trait collection to fix a ton of warnings and remove code * Support Xcode 9 (iOS 11 SDK) * Hack harder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was pretty messy.
This does include a small breaking change with an easy migration pathway. If users were calling
+[ASTraitCollection traitCollectionWithBlah:AndBlah:Etc:]those are gone now. They were never supposed to be called. But there's an easy migration pathway using+traitCollectionWithASPrimitiveTraitCollection:.