ASThread: Remove Locker, Unlocker, and SharedMutex #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Nov 5, 2018
Closed
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
* ASThread: Remove Locker, Unlocker, and SharedMutex * Remove extra line * Kick the CI * Move C++ down * Fix thing
ernestmama
added a commit
to ernestmama/Texture
that referenced
this pull request
Nov 14, 2018
nguyenhuy
pushed a commit
that referenced
this pull request
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/TextureGroup/Texture/projects/2#card-14537113
Important note: As you skim this diff, it may look like MutexLocker was replaced with UniqueLock. It wasn't. However, in instances where we want to unlock mid-scope, I replaced with UniqueLock to make that possible.
typedef ASDN::UniqueLock std::unique_lock<ASDN::Mutex>for when we want to unlock mid-scope.static auto *globalLock = new ASDN::Mutex.