Skip to content

Ruff fails my pull request despite the issue not being my code #8723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
imengus opened this issue May 12, 2023 · 3 comments · Fixed by #8732
Closed

Ruff fails my pull request despite the issue not being my code #8723

imengus opened this issue May 12, 2023 · 3 comments · Fixed by #8732
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@imengus
Copy link
Contributor

imengus commented May 12, 2023

What would you like to share?

https://github.com/TheAlgorithms/Python/actions/runs/4960833192/jobs/8876852733?pr=8722

"maths/euclidean_distance.py:9:13: UP007 Use X | Y for type annotations"

Additional information

No response
@imengus imengus added the awaiting triage Awaiting triage from a maintainer label May 12, 2023
@cclauss
Copy link
Member

cclauss commented May 14, 2023

@dhruvmanila Can you please suggest fixes?

@ValentinKlinger
Copy link

I've got the same problem and when I solve it, the others test get errors

@dhruvmanila
Copy link
Member

I don't see any problem here. ruff is suggesting some autofixes which should be applied.

I've got the same problem and when I solve it, the others test get errors

What errors? Please provide details in the issue.

@CaedenPH CaedenPH mentioned this issue May 14, 2023
Merged
14 tasks
@tianyizheng02 tianyizheng02 mentioned this issue May 17, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct ruff failures CaedenPH/Python
4 participants
@cclauss @dhruvmanila @ValentinKlinger @imengus