Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct ruff failures #8732

Merged
merged 5 commits into from
May 14, 2023
Merged

Correct ruff failures #8732

merged 5 commits into from
May 14, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

Fixes #8723

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@github-actions github-actions bot force-pushed the fix-failing-tests branch from 17a625f to e79403d Compare May 14, 2023 18:14
@CaedenPH CaedenPH changed the title fix: Correct ruff problems Correct ruff failures May 14, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 14, 2023
@CaedenPH
Copy link
Contributor Author

@cclauss Can we merge this to get the repo back to sane?
Strassen has been marked as broken (#8733)

@cclauss cclauss merged commit 1faf10b into TheAlgorithms:master May 14, 2023
@CaedenPH CaedenPH deleted the fix-failing-tests branch May 14, 2023 21:12
This was referenced May 15, 2023
Closed
Merged
Merged
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@CaedenPH @tianyizheng02
Correct ruff failures (TheAlgorithms#8732)
d50f7ea 
* fix: Correct ruff problems

* updating DIRECTORY.md

* fix: Fix pre-commit errors

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Correct ruff failures (TheAlgorithms#8732)
fdfe171 
* fix: Correct ruff problems

* updating DIRECTORY.md

* fix: Fix pre-commit errors

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruff fails my pull request despite the issue not being my code
2 participants
@CaedenPH @cclauss