-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vertex-limited network flow reduction #8720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
""" | ||
|
||
|
||
def vertex_limited(graph, limits): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file networking_flow/vertex_limited.py
, please provide doctest for the function vertex_limited
Please provide return type hint for the function: vertex_limited
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: graph
Please provide type hint for the parameter: limits
It appears that ruff is catching issues from files that I have not modified. I'm not sure what I need to do to get ruff to pass. |
Other people have been having that issue with their PRs too. Try running |
Not sure. It also seems that whether ruff identifies these errors is system-dependent: the errors appear when GitHub Actions runs ruff on my fork but not when I run ruff on my local git repo. @cclauss any ideas on how @iiloni-umd and others can get rid of these ruff errors? |
@iiloni-umd The ruff issue has been fixed in #8732. Update your branch and ruff should pass this time |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@iiloni-umd Could you rebase your branch to bring in the latest commits? The ruff errors have been fixed |
Closing due to lack of response. In addition, please read the contributing guidelines to make sure that your code follows our requirements |
Describe your change:
Implemented a reduction algorithm for flow networks that have capacities on vertices instead of edges. This reduction converts such a flow network into a standard flow network for which the Ford-Fulkerson algorithm can compute a max-flow.
Checklist:
Fixes: #{$ISSUE_NO}
.