Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why am i facing ruff failed on other files? #8935

Closed
Miltonbhowmick opened this issue Aug 9, 2023 · 2 comments · Fixed by #8936
Closed

Why am i facing ruff failed on other files? #8935

Miltonbhowmick opened this issue Aug 9, 2023 · 2 comments · Fixed by #8936
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@Miltonbhowmick
Copy link
Contributor

What would you like to share?

I am trying to add a new algorithm for first time. While i submitting my file and bot is checking for ruff test, its failed on files except my file.
If anyone can help me out of this, i will glad.

PR: https://github.com/TheAlgorithms/Python/actions/runs/5805449154/job/15736567968?pr=8931

Thanks in Advance.

Additional information

No response

@Miltonbhowmick Miltonbhowmick added the awaiting triage Awaiting triage from a maintainer label Aug 9, 2023
@tianyizheng02
Copy link
Contributor

The ruff failures are happening because we recently updated the ruff version. This update caused ruff to detect issues that weren't previously considered errors. I've already been working to address this, and I should have a PR to fix it soon.

@tianyizheng02 tianyizheng02 mentioned this issue Aug 9, 2023
14 tasks
@tianyizheng02
Copy link
Contributor

@Miltonbhowmick The ruff errors have been fixed. To fix the extraneous ruff errors in your PR, you just need to update your PR's branch on your fork of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants