-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruff errors #8936
Fix ruff errors #8936
Conversation
Renamed neural_network/input_data.py to neural_network/input_data.py_tf because it should be left out of the directory for the following reasons: 1. Its sole purpose is to be used by neural_network/gan.py_tf, which is itself left out of the directory because of issues with TensorFlow. 2. It was taken directly from TensorFlow's codebase and is actually already deprecated. If/when neural_network/gan.py_tf is eventually re-added back to the directory, its implementation should be changed to not use neural_network/input_data.py anyway.
Multiple Pull Request Detected@tianyizheng02, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code. This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation. User opened pull requests (including this one): #8936, #8903, #8610, #8603 |
Closing this pull request as invalid@tianyizheng02, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first. Invalid files in this pull request: |
How did neural_network/gan.py_tf make it past this bot then... |
Change input_data.py_tf file extension because algorithms-keeper bot is being picky about it
Please add an issue to rehabilitate |
@dhruvmanila What is your take on ruff rule PYI024? This seems like a lot of rework for minimal gain. Do you believe we should ignore PYI024 or do you see sufficient value in paying attention to this rule? |
The |
@tianyizheng02 if possible, please open any enhancements or bugs related to algorithms-keeper in the repository :) |
* Fix ruff errors Renamed neural_network/input_data.py to neural_network/input_data.py_tf because it should be left out of the directory for the following reasons: 1. Its sole purpose is to be used by neural_network/gan.py_tf, which is itself left out of the directory because of issues with TensorFlow. 2. It was taken directly from TensorFlow's codebase and is actually already deprecated. If/when neural_network/gan.py_tf is eventually re-added back to the directory, its implementation should be changed to not use neural_network/input_data.py anyway. * updating DIRECTORY.md * Change input_data.py_tf file extension Change input_data.py_tf file extension because algorithms-keeper bot is being picky about it --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Describe your change:
Fixes #8935
Fixing ruff errors again due to the recent version update
Notably, I didn't fix the ruff error in neural_network/input_data.py because it appears that the file was taken directly from TensorFlow's codebase, so I don't want to modify it just yet. Instead, I renamed it to neural_network/input_data.py_tf because it should be left out of the directory for the following reasons:
Checklist: