Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy errors in erosion_operation.py #8603

Merged
merged 17 commits into from
Sep 27, 2023
Merged

Fix mypy errors in erosion_operation.py #8603

merged 17 commits into from
Sep 27, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

github-actions and others added 14 commits January 2, 2023 01:57
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Apr 1, 2023
CaedenPH
CaedenPH approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice mypy fixes

@tianyizheng02
Copy link
Contributor Author

@cclauss Mind taking a look? It's pretty much the same changes from #8595

@algorithms-keeper algorithms-keeper bot mentioned this pull request Aug 9, 2023
Merged
14 tasks
@tianyizheng02 tianyizheng02 mentioned this pull request Aug 14, 2023
Merged
15 tasks
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 16, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 16, 2023
@tianyizheng02 tianyizheng02 requested a review from cclauss August 16, 2023 07:43
@tianyizheng02 tianyizheng02 requested a review from cclauss August 17, 2023 21:36
@algorithms-keeper algorithms-keeper bot mentioned this pull request Sep 16, 2023
Closed
14 tasks
@tianyizheng02
Copy link
Contributor Author

@cclauss Pinging for review, the typo that you had brought up in your last review had already been fixed

@cclauss cclauss enabled auto-merge (squash) September 27, 2023 12:00
cclauss
cclauss approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cclauss cclauss merged commit 5830b29 into TheAlgorithms:master Sep 27, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2023
@tianyizheng02 tianyizheng02 deleted the fix-mypy-errs-5 branch September 27, 2023 12:15
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Fix mypy errors in erosion_operation.py (TheAlgorithms#8603)
8c052c6 
* updating DIRECTORY.md

* Fix mypy errors in erosion_operation.py

* Rename functions to use snake case

* updating DIRECTORY.md

* updating DIRECTORY.md

* Replace raw file string with pathlib Path

* Fix function name in erosion_operation.py doctest

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyizheng02 @cclauss @CaedenPH