[FIX:]#10002 #10109
[FIX:]#10002 #10109
Conversation
IndranjanaChatterjee
requested review from
cclauss and
dhruvmanila
as code owners
algorithms-keeper
bot
added
enhancement
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
|
|
||
| def __init__(self) : |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.second_queue=deque() # Second Queue to be used | ||
|
|
||
|
|
||
| def push(self,item:int) : |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
|
@cclauss I have tried to make the required changes . Please review the code . Apologies for the inconveniences caused. |
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class Stack(Generic[T]): # Stack class to implement stack operations | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.insert_queue = deque() # First Queue to be used for inserting | ||
| self.second_queue = deque() # Second Queue to be used | ||
|
|
||
| def push(self, item: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
Describe your change:
Made the changes in the PR #10002 for the issue #9987 .
Fixes:#9987
Checklist: