Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add testcase of polynom_for_points #11811

Merged
merged 3 commits into from
Oct 7, 2024
Merged

feat: add testcase of polynom_for_points #11811

merged 3 commits into from
Oct 7, 2024

Conversation

zeelrupapara
Copy link
Contributor

Describe your change:

  • Add test cases of the polynom_for_points one of the linear algebra algorithms and coverage increase by 5%
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 6, 2024
cclauss
cclauss reviewed Oct 6, 2024
View reviewed changes
linear_algebra/src/polynom_for_points.py Outdated
Comment on lines 30 to 32
>>> print(points_to_polynomial([[1, 1], [1, 2], [1, 3]]))
x=1
>>> print(points_to_polynomial([[1, 1], [2, 2], [2, 2]]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try removing the print()...

Suggested change
>>> print(points_to_polynomial([[1, 1], [1, 2], [1, 3]]))
x=1
>>> print(points_to_polynomial([[1, 1], [2, 2], [2, 2]]))
>>> points_to_polynomial([[1, 1], [1, 2], [1, 3]])
x=1
>>> points_to_polynomial([[1, 1], [2, 2], [2, 2]])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try removing the print()...

@cclauss now check I removed the print statement but I did't see any major change in output

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds right because calling print() is not usually needed in doctests. Can you please remove print() from all tests in this file then I think we can land this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @cclauss check I removed the print from remaining place of polynom_for_points test cases

@cclauss cclauss enabled auto-merge (squash) October 7, 2024 05:43
cclauss
cclauss approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@cclauss cclauss merged commit 3422ebc into TheAlgorithms:master Oct 7, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2024
fortarch pushed a commit to fortarch/algorithms-python that referenced this pull request Oct 7, 2024
@zeelrupapara @fortarch
feat: add testcase of polynom_for_points (TheAlgorithms#11811)
603e345 
* feat: add testcase of polynom_for_points

* fix: remove the print from the testcase of points_to_polynomial

* fix: remove print statement from old test cases
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeelrupapara @cclauss