Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch anime and play and mark as unbroken #8972

Closed

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

Fixes fetch_anime_and_play.py and marks as unbroken. All changes tested and type errors fixed

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@CaedenPH CaedenPH requested a review from cclauss as a code owner August 16, 2023 16:14
@CaedenPH
Copy link
Contributor Author

@cclauss This pr fixes a broken file. Do you mind reviewing?

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran your fixed file locally and I can confirm that it all works. I thought this file was broken because of 403 HTTP errors though (#8762). Did that problem resolve itself? Or does this PR fix that problem?

@CaedenPH
Copy link
Contributor Author

@tianyizheng02 I think it was probably the anime (I think it was demon_slayer?) that failed due to perhaps being made private. Hence the change to the naruto anime

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Aug 18, 2023

Closing because I just realised that this pr fixes two files in one (also fixes broken get_amazon_product_data)

  • Branch issue on my side

@CaedenPH CaedenPH closed this Aug 18, 2023
@tianyizheng02
Copy link
Contributor

I think it was probably the anime (I think it was demon_slayer?) that failed due to perhaps being made private. Hence the change to the naruto anime

@CaedenPH I just tried running the current (broken) fetch_anime_and_play.py file locally again and now it seems to be working again?? So the 403 HTTP error just kinda resolved itself... Could you try running the current file locally and see if it's also fixed for you?

@CaedenPH
Copy link
Contributor Author

@tianyizheng02 Yep seems to work for me as well. This pr just mainly fixes type errors

@CaedenPH CaedenPH deleted the fix-fetch-anime-and-play branch August 21, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants