-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetch anime and play and mark as unbroken #8972
Conversation
@cclauss This pr fixes a broken file. Do you mind reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran your fixed file locally and I can confirm that it all works. I thought this file was broken because of 403 HTTP errors though (#8762). Did that problem resolve itself? Or does this PR fix that problem?
@tianyizheng02 I think it was probably the anime (I think it was demon_slayer?) that failed due to perhaps being made private. Hence the change to the naruto anime |
Closing because I just realised that this pr fixes two files in one (also fixes broken
|
@CaedenPH I just tried running the current (broken) fetch_anime_and_play.py file locally again and now it seems to be working again?? So the 403 HTTP error just kinda resolved itself... Could you try running the current file locally and see if it's also fixed for you? |
@tianyizheng02 Yep seems to work for me as well. This pr just mainly fixes type errors |
Describe your change:
Fixes
fetch_anime_and_play.py
and marks as unbroken. All changes tested and type errors fixedChecklist: