Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmark fetch anime and play as BROKEN and fix type errors #8988

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Unmark fetch anime and play as BROKEN and fix type errors #8988

merged 5 commits into from
Aug 18, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@CaedenPH CaedenPH requested a review from cclauss as a code owner August 18, 2023 12:05
@algorithms-keeper
Copy link

Multiple Pull Request Detected

@CaedenPH, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code.

This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation.

User opened pull requests (including this one): #8988, #8970, #8967, #8966, #8965, #8906

@algorithms-keeper algorithms-keeper bot removed the request for review from cclauss August 18, 2023 12:05
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@CaedenPH
Copy link
Contributor Author

@tianyizheng02 I can't create this pr because I have too many open, can you reopen please

@tianyizheng02 tianyizheng02 reopened this Aug 18, 2023
@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Aug 18, 2023
@tianyizheng02
Copy link
Contributor

Continued from #8972

tianyizheng02
tianyizheng02 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianyizheng02 tianyizheng02 merged commit 945803f into TheAlgorithms:master Aug 18, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@CaedenPH CaedenPH deleted the fetch-anime-and-play branch August 18, 2023 12:22
This was referenced Aug 20, 2023
Closed
Merged
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Unmark fetch anime and play as BROKEN and fix type errors (TheAlgorit…
244e9bf 
…hms#8988)

* updating DIRECTORY.md

* type(fetch-anime-and-play): Fix type errors and re-enable

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @tianyizheng02