Skip to content

Segmented sieve - doctests #9945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 7, 2023
Merged

Segmented sieve - doctests #9945

Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ad217c6
Replacing the generator with numpy vector operations from lu_decompos…
quant12345 Sep 29, 2023
07dfc06
Revert "Replacing the generator with numpy vector operations from lu_…
quant12345 Sep 29, 2023
8a50e77
Merge branch 'TheAlgorithms:master' into master
quant12345 Oct 5, 2023
961e92a
Added doctests.
quant12345 Oct 6, 2023
9b59404
Update segmented_sieve.py
quant12345 Oct 6, 2023
10a46e7
Update segmented_sieve.py
quant12345 Oct 6, 2023
587cdc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2023
3df701a
Update segmented_sieve.py
quant12345 Oct 6, 2023
f261cba
Update segmented_sieve.py
quant12345 Oct 6, 2023
535fcdc
Update segmented_sieve.py
quant12345 Oct 6, 2023
acbac94
Update segmented_sieve.py
quant12345 Oct 6, 2023
9bacc25
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2023
b173e62
Update segmented_sieve.py
quant12345 Oct 6, 2023
f15758c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2023
8c4336c
Update segmented_sieve.py
quant12345 Oct 6, 2023
3de3f75
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2023
496c9a9
ValueError: Number 22.2 must instead be a positive integer
cclauss Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions maths/segmented_sieve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,22 @@


def sieve(n: int) -> list[int]:
"""Segmented Sieve."""
"""
Segmented Sieve.

Examples:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a doctest where the input itself is a prime number. For example,

>>> sieve(29)
[2, 3, 5, 7, 11, 13, 17, 19, 23, 29]

This is to clarify whether the algorithm includes the input number itself or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, please make sure that the function can correctly handle negative and zero inputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianyizheng02 corrected.

>>> sieve(2**3)
[2, 3, 5, 7]

>>> sieve(3**3)
[2, 3, 5, 7, 11, 13, 17, 19, 23]

>>> sieve()
Traceback (most recent call last):
...
TypeError: sieve() missing 1 required positional argument: 'n'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> sieve()
Traceback (most recent call last):
...
TypeError: sieve() missing 1 required positional argument: 'n'

I think it's fine to assume that the function will be called on the right number of inputs, so I don't think this test is necessary

"""
in_prime = []
start = 2
end = int(math.sqrt(n)) # Size of every segment
Expand Down Expand Up @@ -42,4 +57,9 @@ def sieve(n: int) -> list[int]:
return prime


print(sieve(10**6))
if __name__ == "__main__":
import doctest

doctest.testmod()

print(sieve(10**6))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(sieve(10**6))
print(f"{sieve(10**6) = }")