Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only generate AssemblyInfo if Publish is in the FAKE target chain #66

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

TheAngryByrd
Copy link
Owner

Closes #61

Proposed Changes

This makes it so we don't have to generate AssemblyInfo on every build. This can create a lot of churn with AssemblyInfo being modified heavily.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@TheAngryByrd TheAngryByrd force-pushed the 61-generate-assembly-info-on-release branch from 92b6498 to 5fbae3c Compare March 11, 2018 20:36
@TheAngryByrd TheAngryByrd force-pushed the 61-generate-assembly-info-on-release branch from 5fbae3c to a9d03d8 Compare March 11, 2018 20:48
@TheAngryByrd TheAngryByrd merged commit cd73b9e into master Mar 11, 2018
TheAngryByrd pushed a commit that referenced this pull request Mar 11, 2018
* BUGFIX: Only use sourcelink if git dependencies are met (#67)
* MINOR: Only generate AssemblyInfo on Publish (#66)
@TheAngryByrd TheAngryByrd deleted the 61-generate-assembly-info-on-release branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only generate AssemblyInfo on Release
1 participant