Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do sourcelink when there is a remote.origin.url #67

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Mar 11, 2018

closes #36

Proposed Changes

Sourcelink requires a git remote origin for it's tool to run properly. We should only invoke it if that meets requirements.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • have added tests that prove my fix is effective or that my feature works (if appropriate)
  • have added necessary documentation (if appropriate)

Further comments

@TheAngryByrd TheAngryByrd force-pushed the 36-Sourcelink-without-git-remote branch 2 times, most recently from f7f9519 to 40e024d Compare March 11, 2018 21:25
@TheAngryByrd TheAngryByrd force-pushed the 36-Sourcelink-without-git-remote branch from 40e024d to 5846e69 Compare March 11, 2018 22:02
@TheAngryByrd TheAngryByrd merged commit 19d0ab5 into master Mar 11, 2018
TheAngryByrd pushed a commit that referenced this pull request Mar 11, 2018
* BUGFIX: Only use sourcelink if git dependencies are met (#67)
* MINOR: Only generate AssemblyInfo on Publish (#66)
@TheAngryByrd TheAngryByrd deleted the 36-Sourcelink-without-git-remote branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcelink seems to break without a remote git repo
1 participant