Flatten model configuration (i.e. extend from GenerationCommonConfig #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.
This pull request is related to:
I have checked the following:
Description:
Some time ago we, we moved to away from
custom
model parameters in favor of a flattened structure. This change will rectify this for all relevant generative models by creating custom configs schemas that extend fromGenerationCommonConfigSchema
. In the process, I added some better type safety which yielded quite a few bugs. 😄Related issues:
See also: firebase/genkit@6ec91ee