Anthropic: Fix tool calls #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dabolus
previously approved these changes
Jun 4, 2024
|
@MichaelDoyle I just merged the other one and, as you said, I see there are a couple of conflicts. Feel free to ping me once they're resolved |
Update anthropic sdk; tools are GA in the latest release.
|
@Dabolus thanks - went ahead and fixed those conflicts. 😄 |
Dabolus
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update anthropic sdk; tools are GA in the latest release.
Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.
This pull request is related to:
I have checked the following:
Description:
I've been working on testing tool calling with all of the 3P models, and ran into some issues with Anthropic. Particularly, Anthropic will combine text and tool parts together into a single message. It does this to provide chain of thought reasoning for debug purposes. It's also possible to get a batch of tool requests. However, the current plugin will turn these parts into multiple candidates.
Changes
0.22.0which supports tools in GAchoice->event(I think choice was copied over from OpenAI)There's some overlap with #72 wrt Schema config. We should probably merge that one first, and resolve any conflicts here.
Related issues:
N/A