Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting & regroup about 'Health panel' lines. #416

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

Mishasama
Copy link
Contributor

Sorting & regroup about 'Health panel' for new lines.
And replace all 'Tabs' with '4 spaces' to unify the style.

Sorting & regroup about -- Health panel.
And replace all 'Tabs' with '4 spaces' to unify the style.
@Mishasama Mishasama requested a review from nsKpz as a code owner December 25, 2020 20:03
@nsKpz nsKpz merged commit 59bd3ed into TheIndieStone:master Dec 30, 2020
@Mishasama Mishasama deleted the patch-2 branch December 31, 2020 01:19
@Faalagorn
Copy link
Contributor

Faalagorn commented Jan 10, 2021

@Mishasama I saw you left tabs in comments; is it intentional? I've been thinking about running lua linter against whole project to unify the style, though I'm not sure how TranslationZed which is hosted here but technically doesn't have a source code here to fix adapts to it and won't override it anyway.

@Mishasama
Copy link
Contributor Author

@Mishasama I saw you left tabs in comments; is it intentional? I've been thinking about running lua linter against whole project to unify the style, though I'm not sure how TranslationZed which is hosted here but technically doesn't have a source code here to fix adapts to it and won't override it anyway.

Yes, intentional, it should be easier to read on the text editor.

The TranslationZed will delete all comments and change all tabs to 4 spaces, but not sort at all. I don't use it personally. Its only use for me is to track changes.

@Faalagorn
Copy link
Contributor

@Mishasama I saw you left tabs in comments; is it intentional? I've been thinking about running lua linter against whole project to unify the style, though I'm not sure how TranslationZed which is hosted here but technically doesn't have a source code here to fix adapts to it and won't override it anyway.

Yes, intentional, it should be easier to read on the text editor.

The TranslationZed will delete all comments and change all tabs to 4 spaces, but not sort at all. I don't use it personally. Its only use for me is to track changes.

Thanks! I don't use it either, though some future editors might use it. Would be nice if the style could somehow be unified, though we sadly don't have code for TranslationZed as I said to fix it :(

@Mishasama
Copy link
Contributor Author

Thanks! I don't use it either, though some future editors might use it. Would be nice if the style could somehow be unified, though we sadly don't have code for TranslationZed as I said to fix it :(

Uh... Java... Try these...
https://github.com/skylot/jadx/
https://github.com/deathmarine/Luyten
http://jd.benow.ca/

Or just ask TIS...😅

Faalagorn added a commit to Faalagorn/ProjectZomboidTranslations that referenced this pull request Mar 7, 2021
* Changed Freezing time to simply "Freezing" (to be in line with Burning, Cooking, Melting and similar one-worders)
* Removed  the empty spaces after exclamation and before `<CENTRE>` sign in tutorial messages
* Capitalized strength and fitness per overall style guideline (they are skill names)
* Changed Fitness menu entries to title case to be more in-line with other similar menus (Foraging and Fishing)
* Unified 4-space indents, including comments, seems to be most reliable with initial commit 27a4543 where all comments had the same indent. Also see TheIndieStone#416 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants