-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding customization for firefox #107
Conversation
Adding pre-installed addons, change default theme to dark, add bookmarks Co-Authored-By: Skileau <83423277+Skileau@users.noreply.github.com>
Nice one! Did you manage to trust Burp's CA as well? |
No it stays in the todos for now, we will try to look into it later. |
I don't think it's a good idea to generate the burp certificate when building the image and add it to the browser, it's a very big weakness to have a trusted public CA in a browser. So ideally this setup should be done by the entrypoint when creating a new container (by the |
Installing the https://github.com/skylot/jadx/actions/runs/4285932497/jobs/7464839178 Commit : dd51783 So the problem is not related to the installation of |
Agreed, let's make it part of the container creation process, instead of image build |
@wlayzz do you still want to work things out on this PR or is it ready for merge on your end? |
This can be merge as a first iteration, we will continue to improve this feature with other PR laters 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the PR, latests checks are failing due to unrelated network issues
Hi ! 👋
With @Skileau we worked on the issue #90, here is a first PR with a firefox customized by default.
Adding pre-installed addons, change default theme to dark, add bookmarks. 🦊
Add-on added:
Bookmarks is on the places.sqlite: