Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding customization for firefox #107

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

wlayzz
Copy link
Contributor

@wlayzz wlayzz commented Feb 27, 2023

Hi ! 👋
With @Skileau we worked on the issue #90, here is a first PR with a firefox customized by default.
Adding pre-installed addons, change default theme to dark, add bookmarks. 🦊

Add-on added:

  • foxyproxy-standard
  • darkreader
  • uaswitcher
  • cookie-editor
  • wappalyzer

To install other addons, add the link of the addon from the Mozilla store to the array in setup.py (ex: https://addons.mozilla.org/fr/firefox/addon/foxyproxy-standard/).

Bookmarks is on the places.sqlite:

To add new bookmark, open firefox, flush the history, add bookmarks to the current firefox session, close firefox and create a backup of places.sqlite located in /root/.mozilla/firefox/*.Exegol/places.sqlite with the command sqlite3 /root/.mozilla/firefox/*.Exegol/places.sqlite ".backup /workspace/places.sqlite". Then replace the places.sqlite in the firefox folder of this repository.

image

Adding pre-installed addons, change default theme to dark, add bookmarks

Co-Authored-By: Skileau <83423277+Skileau@users.noreply.github.com>
@ShutdownRepo ShutdownRepo self-assigned this Feb 27, 2023
@ShutdownRepo ShutdownRepo added the enhancement New feature or request label Feb 27, 2023
@ShutdownRepo
Copy link
Member

Nice one! Did you manage to trust Burp's CA as well?

@ShutdownRepo ShutdownRepo linked an issue Feb 27, 2023 that may be closed by this pull request
@wlayzz
Copy link
Contributor Author

wlayzz commented Feb 27, 2023

No it stays in the todos for now, we will try to look into it later.

@Dramelac
Copy link
Member

Dramelac commented Feb 28, 2023

Nice one! Did you manage to trust Burp's CA as well?

I don't think it's a good idea to generate the burp certificate when building the image and add it to the browser, it's a very big weakness to have a trusted public CA in a browser.
I don't know exactly when Burp generates its CA but for me it should stay local during the container creation to keep the private and unique side to each profile.

So ideally this setup should be done by the entrypoint when creating a new container (by the load_supported_setups.sh I think)

@QU35T-code
Copy link
Member

QU35T-code commented Feb 28, 2023

Installing the jadx tool from the pipeline didn't work here due to an update to the jadx source repo during testing :

https://github.com/skylot/jadx/actions/runs/4285932497/jobs/7464839178

image

Commit : dd51783

image

So the problem is not related to the installation of firefox.

@ShutdownRepo
Copy link
Member

Nice one! Did you manage to trust Burp's CA as well?

I don't think it's a good idea to generate the burp certificate when building the image and add it to the browser, it's a very big weakness to have a trusted public CA in a browser. I don't know exactly when Burp generates its CA but for me it should stay local during the container creation to keep the private and unique side to each profile.

So ideally this setup should be done by the entrypoint when creating a new container (by the load_supported_setups.sh I think)

Agreed, let's make it part of the container creation process, instead of image build

@ShutdownRepo ShutdownRepo added the ready for merge in the waitlist for merge, requires preliminary steps label Feb 28, 2023
@ShutdownRepo
Copy link
Member

@wlayzz do you still want to work things out on this PR or is it ready for merge on your end?

@Dramelac Dramelac mentioned this pull request Feb 28, 2023
@wlayzz
Copy link
Contributor Author

wlayzz commented Feb 28, 2023

@wlayzz do you still want to work things out on this PR or is it ready for merge on your end?

This can be merge as a first iteration, we will continue to improve this feature with other PR laters 😃

Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR, latests checks are failing due to unrelated network issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for merge in the waitlist for merge, requires preliminary steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-configured Firefox
4 participants