Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Firefox customization issue and added support for addons in my-resources #120

Merged
merged 8 commits into from
Mar 13, 2023

Conversation

Skileau
Copy link
Contributor

@Skileau Skileau commented Mar 8, 2023

Firefox customization now works as announced in PR #107. 🦊
Also, the user is now able to add his favourites addons to each new container with my-resources by two ways.

With a list

It is possible to create a list in ~/.exegol/my-resources/setup/firefox/addons.txt with the links in Mozilla's addon shop :
image

The last versions of the addons will then be downloaded and installed automatically.

With xpi files

It is also possible to directly add .xpi files in the folder ~/.exegol/my-resources/setup/firefox/addons :
image

The addons will then be installed from local .xpi files.

Note : both way can be used simultaneously by just creating the addons.txt and the addons folder.

@ShutdownRepo ShutdownRepo added enhancement New feature or request bugfix It's a bird, it's a plane labels Mar 8, 2023
sources/exegol/load_supported_setups.sh Show resolved Hide resolved
sources/install.sh Show resolved Hide resolved
Skileau and others added 4 commits March 9, 2023 00:42
Added "firefox --version" test command
Added steps to create the firefox/addons directories if missing
@Skileau Skileau requested review from Dramelac and removed request for wlayzz March 9, 2023 09:28
@ShutdownRepo
Copy link
Member

test failure is unrelated to the PR and is due to runner's network instability
pipeline is ok, let's wait for @Dramelac's review

@Dramelac
Copy link
Member

@ShutdownRepo good for merge ?

@ShutdownRepo
Copy link
Member

@Skileau can you confirm custom cert trusting will be handled in another PR?

@Skileau
Copy link
Contributor Author

Skileau commented Mar 13, 2023

@Skileau can you confirm custom cert trusting will be handled in another PR?

Yes, you can merge, I will create a new PR with cert trusting support in the future.
We will define together the structure of the code for this new PR.

@ShutdownRepo ShutdownRepo merged commit 7fc7e0c into ThePorgs:dev Mar 13, 2023
@Skileau Skileau deleted the firefox-dev branch March 13, 2023 15:48
@ShutdownRepo ShutdownRepo mentioned this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix It's a bird, it's a plane enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants