Fix: Remove obsolete structure damage particle effects (#2011)

TheSuperHackers · Jun 18, 2023 · 377eaaa · 377eaaa
1 parent 3f0e53b
commit 377eaaa
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 27 deletions.
diff --git a/Patch104pZH/Design/Changes/v1.0/2011_structure_damage_effects.yaml b/Patch104pZH/Design/Changes/v1.0/2011_structure_damage_effects.yaml
@@ -0,0 +1,20 @@
+---
+date: 2023-06-14
+
+title: Removes obsolete structure damage particle effects
+
+changes:
+  - fix: Removes obsolete structure damage particle effects that would spawn at the center of a building and are not or barely visible.
+
+labels:
+  - art
+  - bug
+  - minor
+  - performance
+  - v1.0
+
+links:
+  - https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2011
+
+authors:
+  - xezon
diff --git a/Patch104pZH/GameFilesEdited/Data/INI/FXList.ini b/Patch104pZH/GameFilesEdited/Data/INI/FXList.ini
@@ -3737,6 +3737,7 @@ FXList FX_HumveeMissileIgnition
   End
 End
 
+; Patch104p @bugfix xezon 14/06/2023 Removes structure damage particle effects that would spawn at the center of a building and are not or barely visible. (#2011)
 ; ----------------------------------------------
 FXList FX_StructureDamaged
   Sound
@@ -3745,47 +3746,49 @@ FXList FX_StructureDamaged
   ViewShake
     Type = NORMAL
   End
-  ParticleSystem
-    Name = StructureDamagedFlash
-  End
-  ParticleSystem
-    Name = StructureDamagedSmoke
-  End
-  ParticleSystem
-    Name = StructureDamagedDebris
-  End
+  ;ParticleSystem
+  ;  Name = StructureDamagedFlash
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedSmoke
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedDebris
+  ;End
 End
 
+; Patch104p @bugfix xezon 14/06/2023 Removes structure damage particle effects that would spawn at the center of a building and are not or barely visible. (#2011)
 ; ----------------------------------------------
 FXList FX_StructureDamagedNoShake
   Sound
     Name = BuildingDamage
   End
-  ParticleSystem
-    Name = StructureDamagedFlash
-  End
-  ParticleSystem
-    Name = StructureDamagedSmoke
-  End
-  ParticleSystem
-    Name = StructureDamagedDebris
-  End
+  ;ParticleSystem
+  ;  Name = StructureDamagedFlash
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedSmoke
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedDebris
+  ;End
 End
 
+; Patch104p @bugfix xezon 14/06/2023 Removes structure damage particle effects that would spawn at the center of a building and are not or barely visible. (#2011)
 ; ----------------------------------------------
 FXList FX_StructureDamagedFlameNoShake
   Sound
     Name = NoSound
   End
-  ParticleSystem
-    Name = StructureDamagedFlash
-  End
-  ParticleSystem
-    Name = StructureDamagedSmoke
-  End
-  ParticleSystem
-    Name = StructureDamagedDebris
-  End
+  ;ParticleSystem
+  ;  Name = StructureDamagedFlash
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedSmoke
+  ;End
+  ;ParticleSystem
+  ;  Name = StructureDamagedDebris
+  ;End
 End
 
 ; ----------------------------------------------