Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove obsolete structure damage particle effects #2011

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jun 14, 2023

This change removes the obsolete structure damage particle effects. Some effects are never visible and others rarely, depending on the geometry of the structure. Despite, the damage particles always spawn at the very center of a structure, which makes no sense when the damage impact is somewhere else.

Original

shot_20230614_174508_4

shot_20230614_174722_6

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern Art Is art related Bug Something is not working right labels Jun 14, 2023
@xezon xezon force-pushed the fix-structure-damage-fx branch from d871e03 to 4cec29c Compare June 18, 2023 10:07
@xezon
Copy link
Collaborator Author

xezon commented Jun 18, 2023

Documentation added. Looks good.

@xezon xezon merged commit 377eaaa into main Jun 18, 2023
@xezon xezon deleted the fix-structure-damage-fx branch June 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant