Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Let Saboteurs Enter Supply Drop Zones And Black Markets (Steal $1000) #547

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 10, 2021

ZH 1.04

  • Saboteurs cannot enter Supply Drop Zones and Black Markets (among other buildings).
  • Since vanilla GLA Saboteurs can enter Fake buildings, including Fake Black Markets, but cannot enter Black Markets, hovering with the cursor above enemy Black Markets can be used to tell fake and real ones apart.

After patch:

  • All Saboteurs can enter Supply Drop Zones and Black Markets. They steal $1000 if they do so, similar to how they steal $1000 when entering a Supply Center or Supply Stash.
  • The cursor can no longer be abused to tell apart real and fake Black Markets.

Sadly, the best way to fix the Saboteur cursor scouting bug is by doing this game design change. I think it's fine in this case, because Saboteurs are kind of lame, and them not being able to enter secondary eco stinks. I realize however that this is a highly controversial change.

Technical aspects: FS_SUPPLY_DROPZONE KindOf is safe to use here. It is only used by the engine to validate targets for the SabotageSupplyDropzoneCrateCollide module.

chatlog with hanfi about FS_SUPPLY_DROPZONE
commy2
Where in engine is FS_SUPPLY_DROPZONE used?
I assume it is related to SabotageSupplyDropzoneCrateCollide. However, my question is if there're any other things that this is used for?

hanfield
only there

commy2
Splendid.
Where is FS_BLACK_MARKET used then? There does not seem to be a related SabotageXXX module.

hanfield
stealthupdate
BlackMarketCheckDelay
combined with NO_BLACK_MARKET forbiddenstealthcondition

commy2
BlackMarketCheckDelay does not seem to be used in 1.04.

hanfield
it works
but it's not used

commy2
Thank you.
Seems interesting. NO_BLACK_MARKET and FS_BLACK_MARKET.

@commy2 commy2 added Bug Something is not working right Design Is a matter of game design Controversial Is controversial labels Oct 10, 2021
@commy2
Copy link
Collaborator Author

commy2 commented Oct 10, 2021

Demo:

sabotage-sdz.mkv.mp4
sabotage-black-market.mkv.mp4

@xezon xezon self-requested a review October 10, 2021 20:51
@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 11, 2021

Looks good, RIP my secret Black Market trick. 😭

I don't think it should be a problem, makes Sabo's a bit more versatile but let's see what others say.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 13, 2021

Just thought of a problem. By doing this, it gives GLAs a 50/50 chance, they might want to steal money but instead end up blowing up a Fake Market.

@xezon
Copy link
Collaborator

xezon commented Oct 13, 2021

I think that is ok. It is a fake market or real market. Attacking player is not supposed to know what he will get. It's the same when you shoot with a SCUD Storm on markets. You will only know afterwards if it was worth the attack.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 13, 2021

Yes that is true, didn't think of that. Then I suppose it's fine.

@commy2 commy2 merged commit 2d73132 into main Oct 16, 2021
@commy2 commy2 deleted the change-saboteur-enter-secondary-eco branch October 16, 2021 13:01
xezon pushed a commit that referenced this pull request Aug 28, 2022
@ImTimK ImTimK added GLA Affects GLA faction Buff Makes a thing more powerful labels Nov 6, 2022
@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Bug Something is not working right Controversial Is controversial Design Is a matter of game design GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants