-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support administrative_contact
and technical_contact
in the Console
#6162
Conversation
I think we'll have to rework the UX here a bit. See also my comment here: I'll look into this later this week/next week. Should not affect the implementation as a whole too much though. |
Currently blocked, so reopening once #6112 is merged. |
This is unblocked. |
151aa13
to
44d54ba
Compare
Does this take in account that in certain deployments collaborators can set only themselves as contacts, but not others (#6378) ? |
Should we inform those users of that, with a notification? @kschiffer |
As far as I understand, we can determine this based on the IS configration fetched from the backend. If indeed the user fan only set itself, the console should deactivate the selector field and render a button 'Set yourself as contact' to the fields. Clicking the button will then put the user into the field. There should also be a notification above the field saying:
|
9876218
to
284993b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Disregard; didn't pull latest changes.
Summary
Closes #6112
Changes
Screenshots
Testing
Manually
Notes for Reviewers
I decided to add this in the entity general settings, as this is the place where I have access to the collaborator's rights for the entity, and not in the user settings as we initially thought.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.