-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit tech admin contact operations via IS config #6378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/identity server
This is related to the Identity Server
compat/api
This could affect API compatibility
compat/db
This could affect Database compatibility
compat/config
This could affect Configuration compatibility
labels
Jul 5, 2023
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
from
July 5, 2023 13:57
5758e84
to
235a825
Compare
adriansmares
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM in general. I have some naming concerns only.
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
from
July 5, 2023 20:38
235a825
to
f65c670
Compare
adriansmares
approved these changes
Jul 7, 2023
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
2 times, most recently
from
July 7, 2023 13:48
aef2064
to
eb316df
Compare
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
from
July 7, 2023 13:53
eb316df
to
2ad5c6e
Compare
adriansmares
reviewed
Jul 7, 2023
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
3 times, most recently
from
July 7, 2023 17:57
61b9ca3
to
2635b5b
Compare
nicholaspcr
added a commit
that referenced
this pull request
Jul 7, 2023
Format files separate PR -> related to #6378
nicholaspcr
force-pushed
the
feature/6323-limit-tech-admin-contact-ops
branch
from
July 7, 2023 18:17
cb5670f
to
5245e76
Compare
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/identity server
This is related to the Identity Server
compat/api
This could affect API compatibility
compat/config
This could affect Configuration compatibility
compat/db
This could affect Database compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6323
Changes
restrictions
field to IS config, alongside the contact info restrictionTesting
Unit tests and manual testing
Regressions
This is a new restriction on any flow that sets the admin/tech contacts which aren't done through the console. So I can't imagine a regression and most likely CLI users aren't setting those contacts since the old way still works (even with the deprecated warning).
Notes for Reviewers
Was going to do a testcase just for restrictions for each registry test file but it felt like overkill, let me know if the smaller tests found currently on the PR are appropriate enough.
If there are any lint errors on CI, I'll run the tests again after the format merge of the separate repository. Made the lint changes into a different PR just to remove it from this PR.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.