Add tags to all instructions also make them to clearly express their purpose #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `model/riscv_insts_zfa.sail`, there are quite a few cases where
spaces (`spc()`) are utilized instead of separators (`sep()`) between operands:
```
mapping clause assembly = RISCV_FMAXM_D(rs2, rs1, rd)
<-> "fmaxm.d" ^ spc() ^ freg_name(rd)
^ spc() ^ freg_name(rs1)
^ spc() ^ freg_name(rs2)
```
In the assembly representation, spaces are between the mnemonic and
its operands, and separators are between operands.
Fix the errant cases.
Signed-off-by: Paul A. Clarke <pclarke@ventanamicro.com>
|
@ThinkOpenly will you please resolve the conflicts and also review the extension function, I have added function into seperate file but I guess we can define the function in correction - I missed out on the defined function, as I was working on the main branch only no need to define that again. |
Sanket-0510
force-pushed
the
main
branch
2 times, most recently
from
9a5d290 to
8a53dd0
Compare
|
I have made the required changes through PR #10 which right now covers check for extension C. In this PR, Facing conflicts as I overlooked the JSON branch. closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4 #5
I have defined a helper function name
extensioninriscv_insts_helperand have included this function to check the extensions of the functions inriscv_insts_*.sailright now it covers "A" and "C" extensions but I will add others also after the feedback.@ThinkOpenly tell me if I am on right track or not, I'll do the required changes in further commits.