Merge #3772

3772: fix: flaky role management test r=jniles a=jniles Wait for checkbox in modal to be clickable before blindly clicking it. Closes #3765 Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Third-Culture-Software · Jun 28, 2019 · 78a657a · 78a657a
2 parents a18c9f5 + c31beee
commit 78a657a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/test/end-to-end/rubricsConfig/rubrics_config.page.js b/test/end-to-end/rubricsConfig/rubrics_config.page.js
@@ -48,6 +48,8 @@ class RubricConfigPage {
     await row.dropdown().click();
     await row.method('configure').click();
 
+    await browser.wait(EC.elementToBeClickable(element(by.id('social'))), 1500);
+
     await element(by.id('social')).click();
     await element(by.id('tax')).click();
 

diff --git a/test/end-to-end/user/roles.page.js b/test/end-to-end/user/roles.page.js
@@ -1,4 +1,5 @@
-/* global by, element */
+/* global element, by, browser */
+const EC = require('protractor').ExpectedConditions;
 const FU = require('../shared/FormUtils');
 const GridRow = require('../shared/GridRow');
 
@@ -38,8 +39,10 @@ class RolesPage {
     await row.menu.$('[data-method="edit-permissions"]').click();
   }
 
-  checkAllPerimission() {
-    return this.checkAll.click();
+  async checkAllPerimission() {
+    const checkbox = this.checkAll;
+    await browser.wait(EC.elementToBeClickable(checkbox), 1500);
+    await checkbox.click();
   }
 
   async assignRole(name) {