Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role Management Tests are flakey #3765

Closed
jniles opened this issue Jun 15, 2019 · 0 comments · Fixed by #3772
Closed

Role Management Tests are flakey #3765

jniles opened this issue Jun 15, 2019 · 0 comments · Fixed by #3772
Assignees
@jniles
Labels
in progress tests

Comments

@jniles
Copy link
Collaborator

jniles commented Jun 15, 2019

See this TravisCI failure for more details.

image

It looks like our Role Management tests are randomly timing out or failing. My assumption is that it is a busy page and we need to use something like protractor's ExpectedConditions to make sure the modal is visible before trying to interact with it.
@jniles jniles added the tests label Jun 15, 2019
@jniles jniles self-assigned this Jun 28, 2019
jniles added a commit to jniles/bhima that referenced this issue Jun 28, 2019
@jniles
fix: flaky role management test
1228b59 
Wait for checkbox in modal to be clickable before blindly clicking it.

Closes Third-Culture-Software#3765
@jniles jniles mentioned this issue Jun 28, 2019
Merged
jniles added a commit to jniles/bhima that referenced this issue Jun 28, 2019
@jniles
fix: flaky role management test
90a6fcb 
Wait for checkbox in modal to be clickable before blindly clicking it.

Closes Third-Culture-Software#3765
bors bot added a commit that referenced this issue Jun 28, 2019
@bors @jniles
Merge #3772
78a657a 
3772: fix: flaky role management test r=jniles a=jniles

Wait for checkbox in modal to be clickable before blindly clicking it.

Closes #3765

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in #3772 Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
in progress tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky role management test jniles/bhima
2 participants
@jniles @kwilu