Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require stock description if we automatically template them in #4082

Closed
jniles opened this issue Jan 13, 2020 · 1 comment · Fixed by #4124
Closed

Do not require stock description if we automatically template them in #4082

jniles opened this issue Jan 13, 2020 · 1 comment · Fixed by #4124
Assignees
@jniles @jeremielodi
Labels
in progress Refactor

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 13, 2020

Thanks to @mbayopanda's PR #4000, we now have automatic templating into our receipts all the relevant information needed for a transaction description. We could do like invoicing and cash payments and remove the requirement for them to be entered by the user. That way, only users who need to add additional information will be required to enter some information.
@jniles
Copy link
Collaborator Author

jniles commented Jan 24, 2020

@kwilu claim

@jniles jniles mentioned this issue Jan 24, 2020
Merged
bors bot added a commit that referenced this issue Jan 24, 2020
@bors @jniles @jeremielodi
Merge #4124 #4125
6cdecbe 
4124: chore(stock): do not require description r=jniles a=jniles

Removes the requirement that a user type a description on entry/exit since we automagically template in that description.

Closes #4082.

4125: Feat(Inventories in stock) considere filters while exporting r=jniles a=jeremielodi

closes #4067

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: jeremielodi <jeremielodi@gmail.com>
@bors bors bot closed this as completed in 6ea9602 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

@jeremielodi jeremielodi

Labels
in progress Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(stock): do not require description jniles/bhima
3 participants
@jniles @jeremielodi @kwilu