Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stock): do not require description #4124

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jan 24, 2020

Removes the requirement that a user type a description on entry/exit since we automagically template in that description.

Closes #4082.

Removes the requirement that a user type a description on entry/exit
since we automagically template in that description.

Closes Third-Culture-Software#4082.
Copy link
Collaborator

@mbayopanda mbayopanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jniles
Copy link
Collaborator Author

jniles commented Jan 24, 2020

Bors r+

bors bot added a commit that referenced this pull request Jan 24, 2020
4124: chore(stock): do not require description r=jniles a=jniles

Removes the requirement that a user type a description on entry/exit since we automagically template in that description.

Closes #4082.

4125: Feat(Inventories in stock) considere filters while exporting r=jniles a=jeremielodi

closes #4067

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: jeremielodi <jeremielodi@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 24, 2020

@bors bors bot merged commit 6ea9602 into Third-Culture-Software:master Jan 24, 2020
@jniles jniles deleted the chore-remove-requirement-on-descrxiption-for-stock-4082 branch January 24, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not require stock description if we automatically template them in
3 participants