Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock Value report crashes server with too much data #4116

Closed
jniles opened this issue Jan 23, 2020 · 4 comments · Fixed by #4556
Closed

Stock Value report crashes server with too much data #4116

jniles opened this issue Jan 23, 2020 · 4 comments · Fixed by #4556
Assignees
@lomamech
Labels
Bug in progress performance

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 23, 2020 •
edited
Loading

As reported by our friends in Vanga, the stock value report appears to crash the server for the "pharmacie usage", the most trafficked depot in the institution. On my local machine, MySQL pins the CPU at 100% and eventually the server dies.

It looks like the entire report is in a stored procedure, which is good, but uses a for loop instead of JOINs/GROUP BYs, which is bad. It appears this report is unusable until rewritten.
@kwilu
Copy link

kwilu commented Mar 23, 2020 •
edited
Loading

Hello @mbayopanda, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @kwilu claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@kwilu kwilu removed the in progress label Apr 10, 2020
@jniles jniles mentioned this issue May 7, 2020
Closed
@lomamech
Copy link
Collaborator

lomamech commented May 7, 2020

@kwilu claim

@kwilu
Copy link

kwilu commented May 18, 2020 •
edited
Loading

Hello @lomamech, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @kwilu claim on that issue.

Thanks for your contributions, and hope to see you again soon!

lomamech added a commit to lomamech/bhima-2.X that referenced this issue May 20, 2020
@lomamech
bug(Stock Value report crashes server with too much data)
930d4dd 
-Analysis of the stock management module, with a view to optimizing the
Stock Value report

closes Third-Culture-Software#4116
@kwilu kwilu removed the in progress label May 26, 2020
@lomamech
Copy link
Collaborator

@kwilu claim

lomamech added a commit to lomamech/bhima-2.X that referenced this issue May 27, 2020
@lomamech
bug(Stock Value report crashes server with too much data)
fbf8aa0 
- Improvement and optimization of the stock value by deposit report

closes Third-Culture-Software#4116
@lomamech lomamech mentioned this issue May 27, 2020
Merged
bors bot added a commit that referenced this issue Jun 3, 2020
@bors @lomamech
Merge #4556
4d04833 
4556: bug(Stock Value report crashes server with too much data) r=jniles a=lomamech

- Improvement and optimization of the stock value by deposit report

closes #4116

Co-authored-by: Chris Lomame <lomamech@gmail.com>
@bors bors bot closed this as completed in 0f656cb Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomamech lomamech

Labels
Bug in progress performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(Stock Value report crashes server with too much data) lomamech/bhima-2.X
4 participants
@jniles @mbayopanda @lomamech @kwilu