Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "cost" column in stock movements registry should have a sum at the bottom #4304

Closed
jniles opened this issue Apr 14, 2020 · 14 comments · Fixed by #5341
Closed

The "cost" column in stock movements registry should have a sum at the bottom #4304

jniles opened this issue Apr 14, 2020 · 14 comments · Fixed by #5341
Labels
Needs Discussion Stock

Comments

@jniles
Copy link
Collaborator

jniles commented Apr 14, 2020 •
edited
Loading

It would be really nice to have the sum in the base of the "cost" column of the stock movement registry. This will let administrators make really quick analyses on the fly. See below:

Test
@jniles
Copy link
Collaborator Author

jniles commented Apr 23, 2020

@lomamech can you work on this?

@lomamech
Copy link
Collaborator

lomamech commented Apr 27, 2020 •
edited
Loading

image

@jniles I do not think that it would be necessary to display the total, just because the movements of stock displays at the same time the entries of stocks as well as the exits, but also this total should have a significant value in the management of stock

@jniles
Copy link
Collaborator Author

jniles commented Apr 27, 2020

@lomamech, you are right that it doesn't make sense in general - it gives a sort of volume of stock. But the problem is we have no easy way to figure out the total value of stock for a given search (such as all entries or exists). If a manager wanted to know this information, where would they look?

@lomamech
Copy link
Collaborator

@lomamech, you are right that it doesn't make sense in general - it gives a sort of volume of stock. But the problem is we have no easy way to figure out the total value of stock for a given search (such as all entries or exists). If a manager wanted to know this information, where would they look?

image
This report makes it easy to know the stock value

@jniles
Copy link
Collaborator Author

jniles commented Apr 27, 2020 •
edited
Loading

How do we filter stock given to one service? Or to one patient? Or to one particular inventory item? Or assigned to one invoice?

@lomamech
Copy link
Collaborator

How do we filter stock given to one service? Or to one patient? Or to one particular inventory item? Or assigned to one invoice?

I think we can add this filter, since we have all the elements

@lomamech
Copy link
Collaborator

@jniles What the continuation of this issue, should I add filters to be able to filter by

  • Patients
  • Service
    and others

@jniles
Copy link
Collaborator Author

jniles commented Apr 30, 2020

@lomamech, I've been thinking about this for a couple of days. I think the only case it doesn't make sense to SUM the values, is when you have entry + exit. Could we just show the total at the bottom of the registry if the registry is filtered on entry or exit?

@lomamech
Copy link
Collaborator

@lomamech, I've been thinking about this for a couple of days. I think the only case it doesn't make sense to SUM the values, is when you have entry + exit. Could we just show the total at the bottom of the registry if the registry is filtered on entry or exit?

There will also be another problem, if there are a lot of inter depot movements, imagine that the same item must enter the central depot, then enter the small pharmacy

@jniles
Copy link
Collaborator Author

jniles commented Apr 30, 2020

@lomamech good point.

What do you suggest to allow our clients to get this information easily?

@lomamech
Copy link
Collaborator

lomamech commented May 7, 2020

@lomamech good point.

What do you suggest to allow our clients to get this information easily?

I think we can be content with the report
This report shows the current stock value for each inventory in a depot

image

@jniles
Copy link
Collaborator Author

jniles commented May 7, 2020

This report is currently broken. See #4116. Would you like to work on it?

@lomamech
Copy link
Collaborator

lomamech commented May 7, 2020

This report is currently broken. See #4116. Would you like to work on it?

I Will do

@kwilu
Copy link

kwilu commented May 18, 2020 •
edited
Loading

Hello @lomamech, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @kwilu claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@kwilu kwilu removed the in progress label May 26, 2020
jniles added a commit to jniles/bhima that referenced this issue Mar 3, 2021
@jniles
feat(stock): add dynamic sum to movements registry
5df3f11 
This commit adds a dynamic sum to the movements registry to allow us to
quickly sum the outgoing medications.

Closes Third-Culture-Software#4304.
@jniles jniles mentioned this issue Mar 3, 2021
Merged
bors bot added a commit that referenced this issue Mar 3, 2021
@bors @jniles
Merge #5459
5d25ac0 
5459: Improvements to Stock Movement Registry r=lomamech a=jniles

This commit moves the flux column over to the I/O column so that a user can more easily determine the reason for the directionality of the flow.

Partially addresses #5424.

This commit adds a dynamic sum to the movements registry to allow us to quickly sum the outgoing medications.  Here is what that looks like:

![UIZvL5Q21G](https://user-images.githubusercontent.com/896472/109820956-c8dd7680-7c35-11eb-98ed-34723dbe9fac.gif)


Closes #4304.



Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@jniles jniles mentioned this issue Mar 4, 2021
Merged
bors bot added a commit that referenced this issue Mar 4, 2021
@bors @jniles
@jmcameron @dependabot-preview
Merge #5341
35d823e 
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@bors bors bot closed this as completed in #5341 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Stock Management Third-Culture-Software/bhima
4 participants
@jmcameron @jniles @lomamech @kwilu