Rename at_risk flag to at_risk_of_stock_out
#5447
Comments
This was referenced Mar 2, 2021
bors bot
added a commit
that referenced
this issue
Mar 4, 2021
5341: Refactor: Stock Management r=jniles a=jniles This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management. It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole. The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`. Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch. ### Issues Closed by the PR Closes #4304. Closes #5073. Closes #5144. Closes #5183. Closes #5185. Closes #5186. Closes #5291. Closes #5311. Closes #5319. Closes #5322. Closes #5325. Closes #5326. Closes #5327. Closes #5328. Closes #5332. Closes #5333. Closes #5349. Closes #5354. Closes #5360. Closes #5416. Closes #5422. Closes #5430. Closes #5431. Closes #5444. Closes #5447. ### Things to Test Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N) -- | -- | -- | -- | -- | -- Rapports > Articles en Stock | @mbayopanda | Status, CMM, etc broken | N | Y | Rapports > Comparaison des articles factures sur les recus | @jniles | #5414 | Y | N | Rapports > Consommations Menseulles | @jmcameron | SQL Error | Y | Y | Y (#5436) Rapports > Entrees des stocks | @mbayopanda | | Y | N | Rapports > Fiche de stock | @jniles | #5415 | Y | Y | Y (#5415) Rapports > Rapport d'expiration | @jmcameron | | Y | Y | Y (#5438) Rapports > Rapport graphique des mouvements | @mbayopanda | #5416 | Y | N | Rapports > Sorties des stocks | @jniles | #5419 | Y | N | Rapports > Valeur de stock | @jmcameron | OK | Y | N | Rapports > Rapport graphique de la consommation de stock | @mbayopanda | #5418 | Y | N | Rapports > Rapport sur les variations de stock | @jniles | OK | Y | N | Stock > Ajustement | @jmcameron | OK | Y | N | Stock > Ajustement des stocks | @mbayopanda | #5428 | Y | N | N | Stock > Articles en stock | @jniles | #5422 | Y | Y | Y( #5432) Stock > Assignation de stock | @jmcameron | Y | Y | N | Stock > Entrée de stock | @mbayopanda | #5429 is related to purchase analysis | Y | N | Stock > Gestion de depots | @jniles | #5423 | Y | N | Stock > Importation de stock | @jmcameron | N (wrong num args) | N #5426 | Y | Y (#5427) Stock > Lots en stock | @mbayopanda | #5430, #5431 | Y, Y | N, Y | Stock > Movements de stock | @jniles | #5424 | Y | Y | Y(#5459) Stock > Parametres de stock | @jmcameron | Seems OK | Y | N | Stock > Requisition | @mbayopanda | Seems OK | Y | N | Stock > Sortie de stock | @jniles | #5425 | N | N | Stock > Tableau de bord | @jmcameron | #5400 (comment) | Y | N | I've left @lomamech off this list because I believe he is working on a separate PR. If he gets done with that, we'll move some of these over to him. @mbayopanda can you review the titles of these modules? I think the French may be wrong for some of them. For example, I don't understand why we have "Ajustement des stocks" and "value de stock". Shouldn't we use "des stocks" or "de stock" in every one? Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Jonathan Cameron <jmcameron@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #5438 (review), we need to rename the
at_riskflag toat_risk_of_stock_outon therefactor-stock-managementbranch. Yes, it is more wordy. But it is also much clearer.One issue we have on our stock routes is that sometimes routes with "lots" return "inventory articles", not lots. Further, to calculate the risk of expiration of an inventory item, you need to know the risk of expiration of each lot, and the order in which they will be consumed (see #5292). So we often can't tell if we are dealing with lots or inventory items from the data returned. This means we need to have really clear naming of our properties so that we avoid confusion in the future.
The text was updated successfully, but these errors were encountered: