Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Sorties de Stocks #5425

Open
jniles opened this issue Feb 24, 2021 · 1 comment
Open

Improvements to Sorties de Stocks #5425

jniles opened this issue Feb 24, 2021 · 1 comment

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 24, 2021

This issue details suggestions/improvements/bugs found while reviewing #5341.

Bug: Submit button can be active while form is invalid

The submit button can be active when the form isn't valid. This is a corner case that happens when the date is changed. I think this is due to asynchronous validation that waits to block the submit button until the HTTP request is finished returning from the server. It's pretty easy to reproduce though:

Tk2thkHu5h

This bug exists on master, so it does not block #5341. It is a critical bug though and should be addressed as soon as possible.

Proposal: if only one lot exists for an inventory item, auto-select it

On the stock exit, when we have a single lot for an inventory item, let's select it by default. There is a slight risk that users will start to be lazy and no longer check that the lot is the correct lot. However, I think the benefit to power users outweighs the risk of laziness.

I've discussed this proposal with @lomamech in person and he agrees with it as well.

Feature Request: Implement caching of the exit grid

In invoices, we have the ability to cache the grid when we submit, and restore it via a button. From a user perspective, it would be useful to do this for the stock exit. We would need to move a lot of our validation checks from the client to the server though, to prevent errors happening from stale data.

Motivation: for the Health Zone project, users often get to the very end of an exit document, realize they need to change the date and that erases all their work - sometimes hours of work. This is worth implementing to avoid this scenario, despite the development complexity.

@jniles
Copy link
Collaborator Author

jniles commented Mar 3, 2021

I'm going to tackle the "invalid submit button" states part of this issue.

jniles added a commit to jniles/bhima that referenced this issue Mar 3, 2021
This commit ensures the submit button on the exit module is only active
when the form is valid for submission.  Previously, there was a corner
case where we would enable the submit button after a date change,
despite not having valid data.

Partially addresses Third-Culture-Software#5425.
bors bot added a commit that referenced this issue Mar 4, 2021
5454: fix(stock): submit button active only when valid on exit r=lomamech a=jniles

This commit ensures the submit button on the exit module is only active
when the form is valid for submission.  Previously, there was a corner
case where we would enable the submit button after a date change,
despite not having valid data.

Partially addresses #5425.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
bors bot added a commit that referenced this issue Mar 4, 2021
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant