Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the "Articles in Stock" registry #5422

Closed
jniles opened this issue Feb 24, 2021 · 1 comment · Fixed by #5341
Closed

Improvements to the "Articles in Stock" registry #5422

jniles opened this issue Feb 24, 2021 · 1 comment · Fixed by #5341
Assignees
@jniles
Labels
Bug priority:urgent Issues that should be tackled as soon as possible Stock

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 24, 2021 •
edited
Loading

This issue is remarks made while working on #5341.

Bug: The "at risk of expiration" flag doesn't work

It appears that the "risky lots" check detects lots that are not actually at risk of expiry. Here is an example:
image

And here is the CMM calculation:
image

And finally, the expiration date of these lots:
image

You'll notice that we have plenty of time to consume this medication, and will consume this medication at current CMM rates before they expire. So this flag is not correct.

This is a blocking issue and should be fixed before merging #5341.

Proposal: add a minimum delay to the CMM calculations

This is already documented in #5407.
@jniles jniles mentioned this issue Feb 24, 2021
Merged
@jniles jniles self-assigned this Feb 24, 2021
@jniles
Copy link
Collaborator Author

jniles commented Feb 24, 2021

I'll tackle the bug in the "at risk" calculation.

jniles added a commit to jniles/bhima that referenced this issue Feb 25, 2021
@jniles
fix(stock): make "at risk of expiration" flag work
d7df2de 
This fix restores the functionality of the "at risk of expiration" flag
on the articles in stock registry.  It does not affect the API, just the
internal calculations.

In addition, we also changed the behavior of the articles in stock
action dropdown menu so the link to the stock lots now filters on the
depot and time period in question.

Closes Third-Culture-Software#5422.
@jniles jniles mentioned this issue Feb 25, 2021
Merged
jniles added a commit to jniles/bhima that referenced this issue Feb 26, 2021
@jniles
fix(stock): make "at risk of expiration" flag work
9445799 
This fix restores the functionality of the "at risk of expiration" flag
on the articles in stock registry.  It does not affect the API, just the
internal calculations.

In addition, we also changed the behavior of the articles in stock
action dropdown menu so the link to the stock lots now filters on the
depot and time period in question.

Closes Third-Culture-Software#5422.
@jniles jniles added the priority:urgent Issues that should be tackled as soon as possible label Feb 26, 2021
bors bot added a commit that referenced this issue Mar 1, 2021
@bors @jniles
Merge #5432
48787d7 
5432: fix(stock): make "at risk of expiration" flag work r=jmcameron a=jniles

This fix restores the functionality of the "at risk of expiration" flag
on the articles in stock registry.  It does not affect the API, just the
internal calculations.

In addition, we also changed the behavior of the articles in stock
action dropdown menu so the link to the stock lots now filters on the
depot and time period in question.

![image](https://user-images.githubusercontent.com/896472/109151831-f7a5a980-776a-11eb-8044-0097b0aacd81.png)


Closes #5422.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
bors bot added a commit that referenced this issue Mar 1, 2021
@bors @jniles
Merge #5432
cdf8535 
5432: fix(stock): make "at risk of expiration" flag work r=jniles a=jniles

This fix restores the functionality of the "at risk of expiration" flag
on the articles in stock registry.  It does not affect the API, just the
internal calculations.

In addition, we also changed the behavior of the articles in stock
action dropdown menu so the link to the stock lots now filters on the
depot and time period in question.

![image](https://user-images.githubusercontent.com/896472/109151831-f7a5a980-776a-11eb-8044-0097b0aacd81.png)


Closes #5422.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
mbayopanda pushed a commit to mbayopanda/bhima that referenced this issue Mar 2, 2021
@jniles @mbayopanda
fix(stock): make "at risk of expiration" flag work
0d228fd 
This fix restores the functionality of the "at risk of expiration" flag
on the articles in stock registry.  It does not affect the API, just the
internal calculations.

In addition, we also changed the behavior of the articles in stock
action dropdown menu so the link to the stock lots now filters on the
depot and time period in question.

Closes Third-Culture-Software#5422.
bors bot added a commit that referenced this issue Mar 4, 2021
@bors @jniles
@jmcameron @dependabot-preview
Merge #5341
35d823e 
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@bors bors bot closed this as completed in #5341 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug priority:urgent Issues that should be tackled as soon as possible Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Stock Management Third-Culture-Software/bhima
1 participant
@jniles