Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the "Rapport des sorties de stocks" report #5419

Closed
jniles opened this issue Feb 23, 2021 · 0 comments · Fixed by #5471
Closed

Improvements to the "Rapport des sorties de stocks" report #5419

jniles opened this issue Feb 23, 2021 · 0 comments · Fixed by #5471
Assignees
@jniles
Labels
Report Stock

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 23, 2021

These are observations/bugs found during the review of #5341.

Proposal: make the titles smaller

Here is what the current version of the report looks like:
image
It doesn't make sense to have the title one size and the total column a different size. We should make them both the same size. I propose we make them both small, since that is how most of our reports work. Saves paper.

Proposal: remove the parentheses from the item type

There isn't any reason to have the parentheses and italics from the item type. Let's remove these decorations and just leave the units next to the value.
@jniles jniles mentioned this issue Feb 23, 2021
Merged
@jniles jniles self-assigned this Mar 3, 2021
jniles added a commit to jniles/bhima that referenced this issue Mar 3, 2021
@jniles
chore(stock): improve exit report formatting
2708803 
This commit improves the stock exit report by:

 1. making the titles smaller
 2. removing the italics and parens around the units

Closes Third-Culture-Software#5419.
@jniles jniles mentioned this issue Mar 3, 2021
Closed
bors bot added a commit that referenced this issue Mar 4, 2021
@bors @jniles
@jmcameron @dependabot-preview
Merge #5341
35d823e 
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jniles added a commit to jniles/bhima that referenced this issue Mar 5, 2021
@jniles
chore(stock): improve exit report formatting
e095ef5 
This commit improves the stock exit report by:

 1. making the titles smaller
 2. removing the italics and parens around the units

Closes Third-Culture-Software#5419.
@jniles jniles mentioned this issue Mar 5, 2021
Merged
jniles added a commit to jniles/bhima that referenced this issue Mar 5, 2021
@jniles
chore(stock): improve exit report formatting
0e04b5a 
This commit improves the stock exit report by:

 1. making the titles smaller
 2. removing the italics and parens around the units

Closes Third-Culture-Software#5419.
bors bot added a commit that referenced this issue Mar 6, 2021
@bors @jniles
Merge #5471
8383e32 
5471: chore(stock): improve exit report formatting r=mbayopanda a=jniles

Restored from #5455

This commit improves the stock exit report by:

 1. making the titles smaller
 2. removing the italics and parens around the units

Closes #5419.

![image](https://user-images.githubusercontent.com/896472/109800622-b6efd980-7c1d-11eb-9455-81f00206c804.png)


Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in c432128 Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Report Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(stock): improve exit report formatting jniles/bhima
1 participant
@jniles