Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with Stock Import #5426

Closed
jmcameron opened this issue Feb 24, 2021 · 2 comments · Fixed by #5427
Closed

Problems with Stock Import #5426

jmcameron opened this issue Feb 24, 2021 · 2 comments · Fixed by #5427
Assignees
@jmcameron

Comments

@jmcameron
Copy link
Collaborator

jmcameron commented Feb 24, 2021 •
edited
Loading

When stock is imported successfully, the Stock Lots page is displayed with a filter for the depot that received the import. Unfortunately, the UUID is shown for the depot in the filter label, not the depot name (in 'master').
image
Note that this filter label works correctly in the stock lots registry when selected by the [Search] filter there.

Also the example import file is broken (includes double-quotes within double-quotes, quoted numbers, etc. These issues will be addressed by one of the fixes in the refactor-stock-management branch.
@jmcameron jmcameron mentioned this issue Feb 24, 2021
Merged
@jmcameron
Copy link
Collaborator Author

Here is an example import file I adapted from the template that works with the IMCK database (rename to *.csv).

test.csv.txt

@jmcameron jmcameron mentioned this issue Feb 24, 2021
Merged
bors bot added a commit that referenced this issue Feb 25, 2021
@bors @jmcameron
Merge #5427
07b5ce1 
5427: Fixed import stock issue r=jniles a=jmcameron

Fixes import stock problem in Refactor Stock Management branch.

Note that Issue #5426 still remains but can be dealt with after merging back to master.

Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
@jniles
Copy link
Collaborator

jniles commented Feb 25, 2021

This would be because of a broken filter label somewhere. I wonder if we changed it in a SQL query. Certainly that is what happened in #5430

@jmcameron jmcameron mentioned this issue Feb 25, 2021
Merged
@jmcameron jmcameron linked a pull request Mar 3, 2021 that will close this issue
Fixed import stock issue #5427
Merged
@jmcameron jmcameron self-assigned this Mar 3, 2021
bors bot added a commit that referenced this issue Mar 4, 2021
@bors @jniles
@jmcameron @dependabot-preview
Merge #5341
35d823e 
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@bors bors bot closed this as completed in 916d394 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcameron jmcameron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed import stock issue jmcameron/bhima
2 participants
@jmcameron @jniles