Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with stock import depot label #5433

Conversation

jmcameron
Copy link
Collaborator

This fixes a cosmetic problem with Stock Import: Once a successful stock import is performed, the result is shown in Stock Lots. But the Depot filter was shown as the UUID. This PR fixes that issue.

Note that this is a fix for the refactor-stock-management branch (but could be applied to 'master' after merging.

Closes #5426

TESTING

  • Use any DB
  • Perform a stock import (example file attached, rename to .csv).
  • Notice that the depot label is now correct. See the screenshot below:

image

test.csv,txt

@jmcameron jmcameron requested a review from mbayopanda February 25, 2021 19:06
Copy link
Collaborator

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 26, 2021

Build succeeded:

@bors bors bot merged commit 916d394 into Third-Culture-Software:refactor-stock-management Feb 26, 2021
@jmcameron jmcameron deleted the fix-stock-import-filter-label branch February 26, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants