Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking from the Articles in Stock registry to the Stock Movements registry should filter by depot by default #5327

Closed
jniles opened this issue Jan 30, 2021 · 1 comment · Fixed by #5341
Closed

Linking from the Articles in Stock registry to the Stock Movements registry should filter by depot by default #5327

jniles opened this issue Jan 30, 2021 · 1 comment · Fixed by #5341
Assignees
@jniles
Labels
Refactor Stock

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 30, 2021

In the "action" menu of the "articles in stock" registry, when you click to view stock movements it shows you all stock movements for that inventory item, even though the data you may want to follow up on (CMM, quantity in stock) is partitioned by the depot you are currently in.

In my view, this should not be the default. It's much easier to remove the depot filter than to add it, and in general, my follow-ups are to try and verify the information in the Articles in Stock registry. Let's change this behavior to filtering by the depot by default as well.
@jniles jniles self-assigned this Feb 1, 2021
@jniles
Copy link
Collaborator Author

jniles commented Feb 1, 2021

I'll tackle this.

@jniles jniles mentioned this issue Feb 1, 2021
Merged
bors bot added a commit that referenced this issue Feb 2, 2021
@bors @jniles
Merge #5334
fa68568 
5334: feat(stock): default filter on depot for movements r=jniles a=jniles

Adds a default filter on the link from the Articles in Stock registry to the stock movements registry to filter by the depot.

Closes #5327.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@jniles jniles mentioned this issue Feb 4, 2021
Merged
jniles added a commit to jniles/bhima that referenced this issue Feb 17, 2021
@jniles
feat(stock): default filter on depot for movements
cfa96ed 
Adds a default filter on the link from the Articles in Stock registry to
the stock movements registry to filter by the depot.

Closes Third-Culture-Software#5327.
jniles added a commit to jniles/bhima that referenced this issue Feb 23, 2021
@jniles
feat(stock): default filter on depot for movements
028e53f 
Adds a default filter on the link from the Articles in Stock registry to
the stock movements registry to filter by the depot.

Closes Third-Culture-Software#5327.
mbayopanda pushed a commit to mbayopanda/bhima that referenced this issue Mar 2, 2021
@jniles @mbayopanda
feat(stock): default filter on depot for movements
3b63229 
Adds a default filter on the link from the Articles in Stock registry to
the stock movements registry to filter by the depot.

Closes Third-Culture-Software#5327.
bors bot added a commit that referenced this issue Mar 4, 2021
@bors @jniles
@jmcameron @dependabot-preview
Merge #5341
35d823e 
5341: Refactor: Stock Management r=jniles a=jniles

This is the off-main-branch work that @jmcameron and @jniles are working on to refactor stock management.  It shouldn't be merged until we have finished all the major stock management upgrades and can test it as a whole.

The goal of this branch is to do a major upgrade to our stock management modules that may have far reaching implications and are integrated too tightly to be able to do progressively on `master`.  Basically, we'll relax our requirements to allow ourselves to "break things" temporarily on this branch, then have a single large merge into the main branch.

### Issues Closed by the PR

Closes #4304.    
Closes #5073.    
Closes #5144.    
Closes #5183.    
Closes #5185.    
Closes #5186.    
Closes #5291.    
Closes #5311.    
Closes #5319.    
Closes #5322.    
Closes #5325.    
Closes #5326.    
Closes #5327.    
Closes #5328.    
Closes #5332.    
Closes #5333.    
Closes #5349.    
Closes #5354.    
Closes #5360.    
Closes #5416.    
Closes #5422.    
Closes #5430.    
Closes #5431.    
Closes #5444.    
Closes #5447. 

 ### Things to Test

Report/Module | Assigned to | Issues Found | Works on master? (Y/N) | Fix Here? (Y/N) | Fixed? (Y/N)
-- | -- | -- | -- | -- | --
Rapports >   Articles en Stock | @mbayopanda | Status, CMM, etc broken | N  | Y  |  
Rapports >   Comparaison des articles factures sur les recus |  @jniles |  #5414 | Y | N |  
Rapports >   Consommations Menseulles | @jmcameron   |  SQL Error  | Y  | Y  |   Y (#5436)
Rapports >   Entrees des stocks | @mbayopanda   |   | Y  | N  |  
Rapports >   Fiche de stock |  @jniles   | #5415  |  Y | Y  | Y (#5415)
Rapports >   Rapport d'expiration | @jmcameron   |   |  Y  | Y  |  Y (#5438)
Rapports >   Rapport graphique des mouvements |  @mbayopanda   |  #5416  | Y | N  |  
Rapports >   Sorties des stocks | @jniles  | #5419 | Y  |  N |  
Rapports >   Valeur de stock | @jmcameron   | OK  | Y | N  |  
Rapports >   Rapport graphique de la consommation de stock | @mbayopanda   | #5418  | Y  | N  |  
Rapports >   Rapport sur les variations de stock | @jniles  |  OK |  Y  | N  |  
Stock >   Ajustement |  @jmcameron  | OK  | Y | N |  
Stock >   Ajustement des stocks | @mbayopanda   | #5428  | Y | N  | N | 
Stock >   Articles en stock |  @jniles  | #5422  |  Y  | Y  | Y( #5432)
Stock >   Assignation de stock | @jmcameron   | Y | Y | N |  
Stock >   Entrée de stock | @mbayopanda   | #5429 is related to purchase analysis  | Y | N  | 
Stock >   Gestion de depots | @jniles  | #5423  | Y |  N |  
Stock >   Importation de stock |  @jmcameron | N (wrong num args) | N #5426 |  Y |  Y (#5427)
Stock >   Lots en stock |  @mbayopanda | #5430, #5431  | Y, Y  | N, Y  | 
Stock >   Movements de stock | @jniles  | #5424  | Y  | Y |   Y(#5459)
Stock >   Parametres de stock | @jmcameron   | Seems OK  | Y | N |  
Stock >   Requisition | @mbayopanda  | Seems OK   | Y  | N  |  
Stock >   Sortie de stock | @jniles   | #5425 |  N | N  |  
Stock >   Tableau de bord | @jmcameron   |  #5400 (comment)  | Y | N |  

I've left @lomamech off this list because I believe he is working on a separate PR.  If he gets done with that, we'll move some of these over to him.

@mbayopanda can you review the titles of these modules?  I think the French may be wrong for some of them.  For example, I don't understand why we have "Ajustement des stocks" and "value de stock".  Shouldn't we use "des stocks" or "de stock" in every one?

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Cameron <jmcameron@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@bors bors bot closed this as completed in f07a102 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Stock Management Third-Culture-Software/bhima
1 participant
@jniles