Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal to the user that products are expired in the "inventory adjustment" page #5187

Closed
jniles opened this issue Dec 3, 2020 · 0 comments · Fixed by #5316
Closed

Signal to the user that products are expired in the "inventory adjustment" page #5187

jniles opened this issue Dec 3, 2020 · 0 comments · Fixed by #5316
Assignees
@jniles
Labels
priority:urgent Issues that should be tackled as soon as possible proposal Stock

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 3, 2020

Let's put a little icon on the "inventory adjustment" page for stocks that have expired. Typically, you should set them to 0 during the adjustment. See below the items that are expired:

image

It would be nice to put an icon or a color to indicate to the user that these items should be examined with care.

If we really wanted to force the issue, we could automatically set them to 0.
@jniles jniles added the priority:urgent Issues that should be tackled as soon as possible label Jan 12, 2021
@jniles jniles self-assigned this Jan 26, 2021
jniles added a commit to jniles/bhima that referenced this issue Jan 26, 2021
@jniles
feat(stock): highlight expired lots in adjustment
f359195 
Highlights the expired lots in the inventory adjustment module.

Closes Third-Culture-Software#5187.
@jniles jniles mentioned this issue Jan 26, 2021
Merged
bors bot added a commit that referenced this issue Jan 27, 2021
@bors @jniles
Merge #5316
b8198c6 
5316: feat(stock): highlight expired lots in adjustment r=jmcameron a=jniles

Highlights the expired lots in the inventory adjustment module.

This is what it looks like:
![image](https://user-images.githubusercontent.com/896472/105861329-e2fcb700-5fee-11eb-8cf8-6d3172b55286.png)


Closes #5187.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in 621867d Jan 27, 2021
@jniles jniles mentioned this issue Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
priority:urgent Issues that should be tackled as soon as possible proposal Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stock): highlight expired lots in adjustment jniles/bhima
1 participant
@jniles