Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stock): highlight expired lots in adjustment #5316

Merged
merged 2 commits into from
Jan 27, 2021
Merged

feat(stock): highlight expired lots in adjustment #5316

merged 2 commits into from
Jan 27, 2021

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jan 26, 2021

Highlights the expired lots in the inventory adjustment module.

This is what it looks like:
image

Closes #5187.

@jniles jniles requested a review from jmcameron January 26, 2021 14:55
@jniles
feat(stock): highlight expired lots in adjustment
621867d 
Highlights the expired lots in the inventory adjustment module.

Closes Third-Culture-Software#5187.
@jniles jniles force-pushed the 5187-feat-show-expired-medicines-on-stock-adjustments branch from f359195 to 621867d Compare January 26, 2021 14:58
jmcameron
jmcameron approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. I tested it on the IMCK db and bhima_test and the both worked and looked nice.

However, there seems to be a glitch with the translation. Note that the untranslated item:
image

@jniles
fix(stock): properly local i18n translation
c9c59f7 
Fixes feedback from the review.
@jniles
Copy link
Collaborator Author

jniles commented Jan 27, 2021

Fixed!

image

@jmcameron jmcameron self-requested a review January 27, 2021 22:43
jmcameron
jmcameron approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and the translation tokens now work. Looks goo.d

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2021

Build succeeded:

@bors bors bot merged commit b8198c6 into Third-Culture-Software:master Jan 27, 2021
@jniles jniles deleted the 5187-feat-show-expired-medicines-on-stock-adjustments branch January 28, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcameron jmcameron jmcameron approved these changes

Assignees
No one assigned
Labels
Feature Request Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signal to the user that products are expired in the "inventory adjustment" page
2 participants
@jniles @jmcameron