Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide expiration date for assets in stock entry #6588

Closed
jmcameron opened this issue Apr 29, 2022 · 0 comments · Fixed by #6633
Closed

Hide expiration date for assets in stock entry #6588

jmcameron opened this issue Apr 29, 2022 · 0 comments · Fixed by #6633
Assignees
@jniles
Labels
Asset Tracking Stock

Comments

@jmcameron
Copy link
Collaborator

Assets have no expiration dates, so hide/blank out expiration dates for assets in during stock entry and the lots registry.

This was mentioned in closed issue 6581.
@jniles jniles self-assigned this May 25, 2022
@jniles jniles mentioned this issue May 25, 2022
Merged
bors bot added a commit that referenced this issue May 25, 2022
@bors @jniles
Merge #6633
5e0672b 
6633: fix(stock): hide expiration date on asset entry r=jmcameron a=jniles

This commit ensures that the expiration date is hidden on asset entry.

Closes #6588.

To test:
  1. Create or update an asset in the inventory list.
  2. Attempt a stock entry.
  3. Note that the expiration date column in the "Lots" modal is not visible.
  4. Attempt a stock entry with a regular lot.
  5. Note that the column is now visible.

Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors bors bot closed this as completed in 080b941 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Asset Tracking Stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stock): hide expiration date on asset entry jniles/bhima
2 participants
@jmcameron @jniles